-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUILD: introduce "--with-syslog=stderr" option #7827
base: master
Are you sure you want to change the base?
Conversation
2d66009
to
af943cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the patch!
I have just one question, otherwise I'm OK with these changes. Shouldn't the sssd(8) man page be updated to show the loggers ( |
@aplopez, but this is unrelated to this PR.
There is indeed an issue with the man page: |
To test this one can use a copr build from #7832 and run
This helped me to realized there is a bug actually - a new line is missing:
Another problem is that output is intermixed so it's difficult to understand what process output where. |
29e76e7
to
765e844
Compare
Updated. Well, this is better:
but There is no trivial solution for this. But taking into account this is an experimental feature for constrained (systemd/syslog-less) environments like single-app containers, and we aren't going to use/advertise it in Fedora/CS and other regular distributions, imo it's "good enough". |
Gosh! You are right. I mixed everything. |
to be used in containers-like environments where no system wide logger is available.
765e844
to
13ac336
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
to be used in containers-like environments where
no system wide logger is available.