KCM: fix memory leak #7823
Closed
KCM: fix memory leak #7823
+12
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alexey-tikhonov
added
no-backport
alexey-tikhonov
added a commit
to alexey-tikhonov/sssd
that referenced
this pull request
Feb 5, 2025
`ldb_msg_add_value()` makes a copy under the hood, so there is no need to make intermediate copy of `secret` argument. This copy - `secret_val.data` - was left hanging on `sss_sec_ctx`, effectively resulting in a memory leak. This is a backport of SSSD#7823 :fixes:'sssd_kcm' memory leak was fixed.
Closed
aplopez
approved these changes
Feb 5, 2025
alexey-tikhonov
force-pushed
the
kcm-mem-leak-2
branch
from
5d3f318 to
b72e0b6
Compare
|
Added comments and edited commit message. |
The copy of 'secret' argument - `secret_val.data` - was left hanging on `sss_sec_ctx`, effectively resulting in a memory leak. But this copy isn't actually required as this data isn't modified in below operations. Skipping alloc+memcpy+erase is also beneficial performance wise. :fixes:'sssd_kcm' memory leak was fixed.
alexey-tikhonov
force-pushed
the
kcm-mem-leak-2
branch
from
b72e0b6 to
6787c46
Compare
alexey-tikhonov
added a commit
to alexey-tikhonov/sssd
that referenced
this pull request
Feb 5, 2025
The copy of 'secret' argument - `secret_val.data` - was left hanging on `sss_sec_ctx`, effectively resulting in a memory leak. But this copy isn't actually required as this data isn't modified in below operations. This is a backport of SSSD#7823 :fixes:'sssd_kcm' memory leak was fixed.
justin-stephenson
approved these changes
Feb 6, 2025
alexey-tikhonov
added
Accepted
Ready to push
alexey-tikhonov
added a commit
that referenced
this pull request
Feb 7, 2025
The copy of 'secret' argument - `secret_val.data` - was left hanging on `sss_sec_ctx`, effectively resulting in a memory leak. But this copy isn't actually required as this data isn't modified in below operations. This is a backport of #7823 :fixes:'sssd_kcm' memory leak was fixed. Reviewed-by: Alejandro López <[email protected]> Reviewed-by: Justin Stephenson <[email protected]>
alexey-tikhonov
added a commit
that referenced
this pull request
Feb 7, 2025
The copy of 'secret' argument - `secret_val.data` - was left hanging on `sss_sec_ctx`, effectively resulting in a memory leak. But this copy isn't actually required as this data isn't modified in below operations. This is a backport of #7823 :fixes:'sssd_kcm' memory leak was fixed. Reviewed-by: Alejandro López <[email protected]> Reviewed-by: Justin Stephenson <[email protected]> (cherry picked from commit 6aba9a7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy of 'secret' argument -
secret_val.data- was left hanging onsss_sec_ctx, effectively resulting in a memory leak. But this copy isn't actually required as this data isn't modified in below operations.Skipping alloc+memcpy+erase is also beneficial performance wise.
:fixes:'sssd_kcm' memory leak was fixed.