Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete 'files provider' #7815

Closed
wants to merge 5 commits into from
Closed

Delete 'files provider' #7815

wants to merge 5 commits into from

Conversation

alexey-tikhonov
Copy link
Member

@alexey-tikhonov alexey-tikhonov commented Jan 27, 2025 •
edited
Loading

First patch deletes 'local_negative_timeout' (it was an oversight that option support wasn't ifdef-ed by '--with-files-provider').

Patches are kept split to ease review but maybe squashed if needed.

@alexey-tikhonov alexey-tikhonov added no-backport This should go to target branch only. coverity Trigger a coverity scan and removed coverity Trigger a coverity scan labels Jan 27, 2025
@alexey-tikhonov alexey-tikhonov force-pushed the del-files-provider branch 2 times, most recently from c854b46 to 46ecc56 Compare January 28, 2025 16:41
@alexey-tikhonov alexey-tikhonov added the coverity Trigger a coverity scan label Jan 29, 2025
@alexey-tikhonov
Get rid of 'local_negative_timeout' config option
3636f02 
since 'files provider' is being removed.
@alexey-tikhonov
Copy link
Member Author

python-system-tests::black failure in 'src/tests/system/tests/test_cache.py' is not introduced by this PR.

@alexey-tikhonov alexey-tikhonov marked this pull request as ready for review January 30, 2025 11:03
aplopez
aplopez reviewed Jan 31, 2025
View reviewed changes
@aplopez aplopez self-assigned this Jan 31, 2025
@pbrezina pbrezina self-assigned this Jan 31, 2025
@alexey-tikhonov
Copy link
Member Author

Added a patch to fix issue reported by 'black'

@alexey-tikhonov
Delete 'files provider'
0f88222 
:relnote:Previously deprecated `--with-files-provider` configure option
and thus support of 'id_provider = files' were removed.

For those who still were building SSSD with this feature: see
https://sssd.io/docs/files-provider-deprecation.html for replacement
details.
@alexey-tikhonov
IPA: verbosity
7a54540
@alexey-tikhonov
TESTS: fix issue reported by 'black'
fc10ce7
@alexey-tikhonov
Fixed a mistype
54a58da 
CONFDB_RESPONDER_CACHE_FIRST_DEFAILT -> CONFDB_RESPONDER_CACHE_FIRST_DEFAULT
aplopez
aplopez approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@aplopez aplopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you.

pbrezina
pbrezina approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@pbrezina pbrezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally :-) Ack

@alexey-tikhonov alexey-tikhonov added the Ready to push Ready to push label Feb 4, 2025
@alexey-tikhonov
Copy link
Member Author

Pushed PR: #7815

  • master
    • 196ad92 - Fixed a mistype
    • 003c699 - TESTS: fix issue reported by 'black'
    • a71f9a6 - IPA: verbosity
    • 827a9bf - Delete 'files provider'
    • cf65032 - Get rid of 'local_negative_timeout' config option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aplopez aplopez aplopez approved these changes

@pbrezina pbrezina pbrezina approved these changes

Assignees

@aplopez aplopez

@pbrezina pbrezina

Labels
coverity Trigger a coverity scan no-backport This should go to target branch only. Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexey-tikhonov @aplopez @pbrezina