This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
[MIRROR] Blob: Explosive Lattice now actually works, reactive spines retaliation applies reagent, description consistency #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on applies reagent, description consistency (#56884) Co-authored-by: Ranged <[email protected]> Co-authored-by: Rohesie <[email protected]>
…on applies reagent, description consistency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: tgstation/tgstation#56884
About The Pull Request
The Explosive Lattice strain was completely broken. In the images below, the middle mob is attacked once.
It doesn't do an AoE at all, does 5 dmg from the default blob_act on the target, and gives a single guy in the 'AoE' 15 damage.
Explosive Lattice has been changed to use the same damage calculations as ex_act, dealing a mix of brute/burn in the AoE properly.
Additionally, the Reactive Spines retaliation now properly smacks living mobs with the reagents that the strain should apply. A small 2.5 second cooldown has been added between these retaliatory attacks, considering the increased damage they do to mobs now.
The strain effect descriptions were also all over the place in terms of damage applied, and have been made more consistent. E.g. an 0.6 reagent mod was called 'high oxy damage' while a 1.0 mod was called 'medium brute' elsewhere.
Why It's Good For The Game
Blob code is an inconsistent fucking mess that I've been slowly working away at making more bearable, this is another step forward (I hope). Broken strain fixed, another strain's behavior made more sensible, and various comment/description fixes.
Changelog
🆑
add: The Reactive Spines blob strain's retaliation now applies the strain's reagents, and can trigger once every 2.5 seconds.
fix: Fixed and changed the Explosive Lattice blob strain. It didn't work at all, but now actually applies an AoE of light burn/brute.
code: Changed comments and descriptions of various blob strains to be more consistent.
/:cl: