This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
[MIRROR] Fixes cargo barcode payouts paying 50x what the sale is worth #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: code/modules/recycling/sortingmachinery.dm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: tgstation/tgstation#56914
About The Pull Request
Makes it so sales barcodes set the modifier the pricetag component uses to calculate the sale's cut correctly again.
Why It's Good For The Game
People will no longer receive 50x the value of items sold with barcodes on the Supply shuttle.
[issue link stripped]
Changelog
🆑 cacogen
fix: You can no longer receive 50x the value of items sold with barcodes on the Supply shuttle
tweak: Sales barcode profit splits will consistently default to 50% (you can still set this to less, but there's no reason to at the moment)
tweak: Sales tagger examine message improvements
tweak: Sales tagger and GrandArk Exporter tablet app both tell you the valid range to set the profit split in now
spellcheck: 'Barcode tag' is now called 'barcode tag'
/:cl: