This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
[MIRROR] Holodeck Bugs are NOT ALLOWED!!!! Fixes Issue with Holodeck Projectiles #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (#56933) Conflicts: code/modules/projectiles/ammunition/_ammunition.dm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: tgstation/tgstation#56933
About The Pull Request
[issue link stripped] (nice)
the bug report is inaccurate, the holodeck puts the original projectile spawned by the energy guns stored ammo_casing into its spawned list and tracks it normally. whenever its time to delete everything in the spawned list (ie when the holodeck program changes) derez() makes everything with contents move its contents to its loc before being deleted. this is fine for guns that are spawned without being fired because the projectile is in the spawned list as well (and is thus deleted), but if the gun is fired once then the projectile held inside the guns ammo_casing isnt in the spawned list, so it gets moved onto the guns turf and doesnt get deleted. so you now have a stationary laser beam standing there runtiming whenever someone touches it. this pr makes ammo casings qdel their stored projectile in Destroy. I couldnt find anything getting broken by this including ballistics and non holodeck energy guns.
Why It's Good For The Game
holobugs must die!!!
Changelog
🆑
fix: holodeck laser beams no longer get stage fright when their gun houses stop existing unexpectedly
/:cl: