Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frontend build with Angular 16 and update Sprint Boot to version 2 #77

Merged
merged 51 commits into from
Nov 10, 2023
Merged

Fix frontend build with Angular 16 and update Sprint Boot to version 2 #77

merged 51 commits into from
Nov 10, 2023

Conversation

pyby
Copy link
Member

@pyby pyby commented Oct 30, 2023 •
edited
Loading

Motivation and Context

The frontend was too old.
It has to be replaced.

Description

  • Use Node 20.8.0 and npm 10.2.1 to build the frontend app.
  • Updated application in portal-app folder with AngularJS 16.2.0.
  • Upgrade to Sprint Boot to 2.7.17.
  • Add WebMvcConfig to serve frontend app pages. Thanks @jboix.
  • Replace custom login page with the default loginForm from SprintBoot. Thanks @jboix.
  • Add .editorconfig at root to be used in both projects.
  • Add Android application custom requests in code and unit tests, not in read me.
  • Unit tests are running with mvn clean test.

Checklist

  • The branch has been rebased onto the main branch.
  • The green check mark "All checks have passed" is displayed on the PR.
  • The documentation has been updated (if relevant).
  • Issues are linked to the PR, if any.

pyby added 20 commits April 30, 2023 15:47
@pyby
Update frontend-maven-plugin
d87395a
@pyby
Update node and npm versions
bfa424e
@pyby
Create new angular app
45fadf9
@pyby
ng add @ng-bootstrap/ng-bootstrap
699f769
@pyby
Home page
ec183d3
@pyby
Create routes and restore 3 pages
04ffdd5
@pyby
Set app version
58b4bdb
@pyby
Build new frontend with maven
fddb254
@pyby
Revert "Update frontend-maven-plugin"
4d5c570 
This reverts commit d87395a.
@pyby
Fix favicon
880a138
@pyby
Remove portal-app
a1ebbf2
@pyby
Increase budget maximum size
d6a4273
@pyby
Fix warning "Generating index html...2 rules skipped due to selector …
d3ac945 
…errors"
@pyby
Update npm version
8812a35
@pyby
Update html title
00ef3dc
@pyby
Test angular app at root
012fa9b
@pyby
Remove npm deployment in pom.xml
c6f54fc
@pyby
Revert "Remove npm deployment in pom.xml"
ac555de 
This reverts commit c6f54fc.
@pyby
Revert "Test angular app at root"
37d188c 
This reverts commit 012fa9b.
@pyby
Add prod option to build
03e2d9d
@pyby pyby added the bug Something isn't working label Oct 30, 2023
@pyby pyby linked an issue Oct 30, 2023 that may be closed by this pull request
Frontend in Node.js failed during installation #76
Closed
@pyby pyby marked this pull request as draft October 30, 2023 19:32
@pyby pyby temporarily deployed to playfff-dev November 1, 2023 16:20 Inactive
@pyby pyby temporarily deployed to playfff-dev November 1, 2023 16:50 Inactive
@pyby pyby temporarily deployed to playfff-76-fix-frontend-gzvlt1 November 1, 2023 16:52 Inactive
@rts-devops rts-devops temporarily deployed to playfff-76-fix-frontend-gzvlt1 November 1, 2023 16:59 Inactive
@pyby pyby temporarily deployed to playfff-76-fix-frontend-gzvlt1 November 7, 2023 23:32 Inactive
@pyby pyby force-pushed the 76-fix-frontend-build branch from 646c681 to 637e878 Compare November 7, 2023 23:33
@pyby pyby temporarily deployed to playfff-76-fix-frontend-gzvlt1 November 7, 2023 23:33 Inactive
@pyby pyby force-pushed the 76-fix-frontend-build branch from 637e878 to 59102d3 Compare November 8, 2023 13:23
@pyby pyby temporarily deployed to playfff-76-fix-frontend-gzvlt1 November 8, 2023 13:23 Inactive
@pyby pyby temporarily deployed to playfff-76-fix-frontend-gzvlt1 November 8, 2023 17:56 Inactive
@pyby pyby temporarily deployed to playfff-76-fix-frontend-gzvlt1 November 8, 2023 22:27 Inactive
@pyby pyby added the enhancement New feature or request label Nov 8, 2023
@pyby pyby force-pushed the 76-fix-frontend-build branch from 039fe1e to 1543ab1 Compare November 8, 2023 22:55
@pyby pyby temporarily deployed to playfff-76-fix-frontend-gzvlt1 November 8, 2023 22:55 Inactive
@pyby pyby force-pushed the 76-fix-frontend-build branch from 1543ab1 to e3d34c8 Compare November 8, 2023 22:55
@pyby pyby temporarily deployed to playfff-76-fix-frontend-gzvlt1 November 8, 2023 22:56 Inactive
@pyby pyby changed the title Fix frontend build Fix frontend build with Angular 16 and update SprintBoot to version 2 Nov 8, 2023
@pyby pyby changed the title Fix frontend build with Angular 16 and update SprintBoot to version 2 Fix frontend build with Angular 16 and update Sprint Boot to version 2 Nov 8, 2023
@pyby pyby requested a review from jboix November 8, 2023 23:10
@pyby
Copy link
Member Author

pyby commented Nov 8, 2023

  • Unit tests run again on CI and pass.
  • Play Android application custom requests are supported.
  • Cache for api/v2/deeplink/parsePlayUrl.js is working.

jboix
jboix approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@jboix jboix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

portal-app/.gitignore Show resolved Hide resolved
@pyby pyby added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit 4d83349 Nov 10, 2023
@pyby pyby deleted the 76-fix-frontend-build branch November 10, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jboix jboix jboix approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontend in Node.js failed during installation
3 participants
@pyby @jboix @rts-devops