Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYNEXT-195 RTS radio channels update #514

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented Aug 22, 2024

Description

RTS radio channels are updated for 2024 back to school time.

Follow radioChannels remote configuration: https://github.com/SRGSSR/playsrg-apple/blob/develop/docs/REMOTE_CONFIGURATION.md

Changes Made

  • Renaming channel names (for UI).
  • Update but not renaming xc asset resources (to avoid complex remote configurations on old and new apps).
  • Switch 4 radio channels to hasDarkStatusBar as the titleColor is dark (from figma #292929).
  • Use same colors (color, tileColor) as RSI Podcast for the Podcasts channel.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@pyby pyby added the improvement Feature or update (issue and PR) - release notes section label Aug 22, 2024
@pyby pyby requested a review from mutaben August 22, 2024 19:41
@rts-devops rts-devops had a problem deploying to playsrg-tvos-nightly+PLAYNEXT-195-rts-radio-channels-update August 22, 2024 20:04 Error
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-195-rts-radio-channels-update August 23, 2024 11:40 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-195-rts-radio-channels-update August 23, 2024 11:41 Inactive
@pyby pyby requested a review from defagos August 23, 2024 12:01
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-195-rts-radio-channels-update August 23, 2024 18:43 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-195-rts-radio-channels-update August 23, 2024 18:43 Inactive
@pyby pyby added this pull request to the merge queue Aug 26, 2024
Merged via the queue into develop with commit 43cd05f Aug 26, 2024
3 checks passed
@pyby pyby deleted the feature/PLAYNEXT-195-rts-radio-channels-update branch August 26, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants