Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAYRTS-5553 Allow badge to expand horizontally if the contained text is long #493

Merged
merged 2 commits into from
Jun 14, 2024
Merged

PLAYRTS-5553 Allow badge to expand horizontally if the contained text is long #493

merged 2 commits into from
Jun 14, 2024

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented Jun 13, 2024

… is long

Description

If the text within a badge was too long, it was truncated from the head, without growing, even if there was enough room to do so.

This would happen in the featured content view.

Changes Made

  • We raised the priority of the badge view so that it pushes the other view, allowing it to expand horizontally.
  • We updated the SwiftUI previews to reflect this scenario.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the bug Issue to be fix (issue and PR) - release notes section label Jun 13, 2024
@mutaben mutaben requested a review from pyby June 13, 2024 14:47
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5553-fix-feature-content-badge June 13, 2024 14:50 Inactive
@mutaben mutaben enabled auto-merge June 14, 2024 09:15
@mutaben mutaben added this pull request to the merge queue Jun 14, 2024
Merged via the queue into develop with commit 5a634e1 Jun 14, 2024
1 check passed
@mutaben mutaben deleted the feature/PLAYRTS-5553-fix-feature-content-badge branch June 14, 2024 09:18
@pyby pyby mentioned this pull request Jun 14, 2024
Merged
6 tasks
pyby
pyby reviewed Jun 17, 2024
View reviewed changes
Application/Sources/UI/Views/FeaturedContentCell.swift
@@ -192,6 +192,10 @@ struct FeaturedContentCell_Previews: PreviewProvider {
FeaturedContentCell(media: Mock.media(kind), style: .show, label: label, layout: .element)
.previewLayout(for: .element, layoutWidth: 800, horizontalSizeClass: .compact)
.environment(\.horizontalSizeClass, .compact)
#endif

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mutaben Regarding trim trailing whitespace on empty line discussion in #495, it's about this finding. On more I see from last months and from other PRs with our iOS developer colleagues 🍎😊.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyby pyby pyby approved these changes

Assignees
No one assigned
Labels
bug Issue to be fix (issue and PR) - release notes section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mutaben @pyby @rts-devops