Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYRTS-5508 Beta only audio content pages #487

Merged
merged 25 commits into from
Jun 6, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented May 29, 2024

Description

This PR proposes an internal test only for audios tab with two options:

  • use the PAC Audio landing page.
  • use landing page per channel home page, if the channel remote configuration as a contentPageId defined.

It's also propose a internal test for show squared images, if supported by BU.

Changes Made

  • Add contentPageId in channel remote configuration object.
  • Add two settings:
    • AudioHomepageOption to select Audios tab content.
    • SquareImages to force radio show image to square.
    • Update UI if those settings changed.
  • PageViewModel .audio(channel: RadioChannel?) channel Id can have a nullable channel, to support only Play Audio landing page.
  • Introduce ContentType enum to describe videoOrTV, audioOrRadio or mixed content.
  • Use SRGImageVariant on show regarding the ContentType.
  • Update SRGDataProdvier to support podcast show image variant. Add podcast image variant srgdataprovider-apple#65

Some "FIXME" added as for now, a section does not know itself if it's videoOrTV or audioOrRadio content in.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

pyby added 20 commits May 22, 2024 19:20
…splay content audio homepage

Instead of many radio channel homepages
@pyby pyby requested a review from mutaben May 29, 2024 16:46
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5508-audio-content-pages May 29, 2024 16:47 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5508-audio-content-pages May 29, 2024 16:47 Inactive
@pyby pyby changed the title PLAYRTS-5508 POC audio content pages PLAYRTS-5508 Beta only audio content pages May 29, 2024
@pyby pyby marked this pull request as ready for review May 29, 2024 17:07
@pyby pyby added improvement Feature or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section and removed internal Ignore this PR in automatically generated release notes - no release notes section labels May 29, 2024
Using `compactMap` instead of if/else

Co-authored-by: Mustapha-Tarek <[email protected]>
@pyby pyby force-pushed the feature/PLAYRTS-5508-audio-content-pages branch from f78da13 to df97c65 Compare May 31, 2024 11:09
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5508-audio-content-pages May 31, 2024 13:17 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5508-audio-content-pages May 31, 2024 13:18 Inactive
@pyby pyby added this pull request to the merge queue Jun 6, 2024
Merged via the queue into develop with commit a013070 Jun 6, 2024
1 check passed
@pyby pyby deleted the feature/PLAYRTS-5508-audio-content-pages branch June 6, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants