-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAYRTS-5533 Replace component for radio tabs #486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutaben
force-pushed
the
feature/PLAYRTS-5533-tabar-component-fix
branch
from
May 29, 2024 19:56
3cf2f66
to
a41e894
Compare
mutaben
added
the
maintenance
Code maintenance (issue and PR) - release notes section
label
May 29, 2024
rts-devops
had a problem deploying
to
playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix
May 30, 2024 07:57
Error
rts-devops
temporarily deployed
to
playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix
May 30, 2024 15:10
Inactive
mutaben
force-pushed
the
feature/PLAYRTS-5533-tabar-component-fix
branch
from
May 31, 2024 13:30
4b7cb7c
to
3740d81
Compare
rts-devops
temporarily deployed
to
playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix
May 31, 2024 14:04
Inactive
pyby
reviewed
Jun 1, 2024
Application/Sources/UI/Controllers/TabContainerViewController.swift
Outdated
Show resolved
Hide resolved
Application/Sources/UI/Controllers/PageContainerViewController.swift
Outdated
Show resolved
Hide resolved
Application/Sources/UI/Controllers/PageContainerViewController.swift
Outdated
Show resolved
Hide resolved
Application/Sources/UI/Controllers/PageContainerViewController.swift
Outdated
Show resolved
Hide resolved
Application/Sources/UI/Controllers/PageContainerViewController.swift
Outdated
Show resolved
Hide resolved
Application/Sources/UI/Controllers/TabContainerViewController.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Pierre-Yves <[email protected]>
… the radio view controllers are not needed
rts-devops
had a problem deploying
to
playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix
June 3, 2024 09:00
Error
rts-devops
temporarily deployed
to
playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix
June 5, 2024 21:56
Inactive
pyby
approved these changes
Jun 5, 2024
rts-devops
temporarily deployed
to
playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix
June 5, 2024 22:52
Inactive
…ebounce in order to avoid UI glitches and not refresh too often
mutaben
commented
Jun 6, 2024
rts-devops
had a problem deploying
to
playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix
June 6, 2024 10:10
Error
rts-devops
temporarily deployed
to
playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix
June 6, 2024 10:21
Inactive
rts-devops
temporarily deployed
to
playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix
June 6, 2024 13:20
Inactive
rts-devops
temporarily deployed
to
playsrg-tvos-nightly+PLAYRTS-5533-tabar-component-fix
June 6, 2024 13:20
Inactive
rts-devops
temporarily deployed
to
playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix
June 7, 2024 08:19
Inactive
pyby
approved these changes
Jun 7, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The component to make Android like tabs for switching between radios was outdated and causing crashes on VisionOS.
The goal here is to replace the implementation with a more modern and supported dependency, while keeping the same look and feel.
Changes Made
Replaced the tab implementation in
RadioChannelsViewController
and its superclassPageContainerViewController
.Checklist