Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYRTS-5533 Replace component for radio tabs #486

Merged
merged 32 commits into from
Jun 7, 2024

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented May 28, 2024

Description

The component to make Android like tabs for switching between radios was outdated and causing crashes on VisionOS.
The goal here is to replace the implementation with a more modern and supported dependency, while keeping the same look and feel.

Changes Made

Replaced the tab implementation in RadioChannelsViewController and its superclass PageContainerViewController.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben force-pushed the feature/PLAYRTS-5533-tabar-component-fix branch from 3cf2f66 to a41e894 Compare May 29, 2024 19:56
@mutaben mutaben requested a review from pyby May 29, 2024 20:01
@mutaben mutaben marked this pull request as ready for review May 29, 2024 20:01
@mutaben mutaben added the maintenance Code maintenance (issue and PR) - release notes section label May 29, 2024
@rts-devops rts-devops had a problem deploying to playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix May 30, 2024 07:57 Error
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix May 30, 2024 15:10 Inactive
@mutaben mutaben force-pushed the feature/PLAYRTS-5533-tabar-component-fix branch from 4b7cb7c to 3740d81 Compare May 31, 2024 13:30
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix May 31, 2024 14:04 Inactive
@mutaben mutaben requested a review from pyby June 3, 2024 08:57
@rts-devops rts-devops had a problem deploying to playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix June 3, 2024 09:00 Error
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix June 5, 2024 21:56 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix June 5, 2024 22:52 Inactive
…ebounce in order to avoid UI glitches and not refresh too often
@mutaben mutaben requested a review from pyby June 6, 2024 10:06
@rts-devops rts-devops had a problem deploying to playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix June 6, 2024 10:10 Error
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix June 6, 2024 10:21 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix June 6, 2024 13:20 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5533-tabar-component-fix June 6, 2024 13:20 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5533-tabar-component-fix June 7, 2024 08:19 Inactive
@mutaben mutaben added this pull request to the merge queue Jun 7, 2024
Merged via the queue into develop with commit b37ee6d Jun 7, 2024
1 check passed
@mutaben mutaben deleted the feature/PLAYRTS-5533-tabar-component-fix branch June 7, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code maintenance (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when running on visionOS 1.0 when opening Audios tab (Designed for iPad)
3 participants