Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message (PLAYRTS-5527) #481

Merged
merged 2 commits into from
May 19, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented May 17, 2024

Description

Following #479 , a test when a content page is not avaible, the error message on iOS was too technical.
The PR propose to use same user error message as used in deep links.

Currently Proposition
Banner error message - before Banner error message - after

Code path to test: Test swimlane page link not found.patch

Changes Made

  • Update banner error message with page section link to micro page can't be loaded.
  • Update translation files, according to.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@pyby pyby added improvement Feature or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section labels May 17, 2024
@pyby pyby requested a review from mutaben May 17, 2024 18:20
@pyby pyby enabled auto-merge May 17, 2024 18:27
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5527-swimlane-link-to-micropage May 18, 2024 18:32 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5527-swimlane-link-to-micropage May 18, 2024 18:32 Inactive
@pyby pyby added this pull request to the merge queue May 19, 2024
Merged via the queue into develop with commit ee59886 May 19, 2024
3 checks passed
@pyby pyby deleted the feature/PLAYRTS-5527-swimlane-link-to-micropage branch May 19, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants