Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR template #472

Merged
merged 1 commit into from
May 7, 2024
Merged

Update PR template #472

merged 1 commit into from
May 7, 2024

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented May 7, 2024

Description

Update PR template to reflect the fact that we don't have (yet) unit/UI/snapshot tests.
Instead, make sure it's understood that we must test manually.

Changes Made

Only changed a sentence in the PR template.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the dev tool Dev tool improvement or update (issue and PR) - release notes section label May 7, 2024
@mutaben mutaben requested a review from pyby May 7, 2024 14:56
@pyby
Copy link
Member

pyby commented May 7, 2024

Following #472 . Thanks.

@mutaben mutaben added this pull request to the merge queue May 7, 2024
Merged via the queue into develop with commit 2b7919d May 7, 2024
1 check passed
@mutaben mutaben deleted the feature/update-pr-template branch May 7, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyby pyby pyby approved these changes

Assignees
No one assigned
Labels
dev tool Dev tool improvement or update (issue and PR) - release notes section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mutaben @pyby