Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Beta and TestFlight tag Github deployments #465

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

pyby
Copy link
Member

@pyby pyby commented Apr 26, 2024

Motivation and Context

Topic: #447.

AppStoreBuilds and TestFlight public distributions not work as expected with #464.
Only tag deployments should be used if scripts runs on the tagged commit.

Investigate and fix it.

Description

  • Fixing the sh command. It returned a breaking line, which brake the commit sha comparaison.

Checklist

  • The branch should be rebased onto the develop branch for whole tests with nighties, but it's not required.*
  • The code followed the code style as make quality passes with a green tick on the last commit.
  • Remote configuration properties have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • Issues are linked to the PR, if any.

* The project uses Github merge queue feature, which rebases onto the develop branch before squashing and merging the PR.

The sh command returns a breaking line
@pyby pyby added dev tool Dev tool improvement or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section labels Apr 26, 2024
@pyby pyby changed the title Fix commit sha comparaison Fix Beta and TestFlight tag Github deployments Apr 26, 2024
@pyby pyby added this pull request to the merge queue Apr 26, 2024
Merged via the queue into develop with commit 0f26440 Apr 26, 2024
1 check passed
@pyby pyby deleted the feature/ci-update branch April 26, 2024 21:22
@pyby pyby added CI CI workflow improvement or update (issue and PR) - release notes section and removed dev tool Dev tool improvement or update (issue and PR) - release notes section labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI workflow improvement or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant