-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github production deployments #462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyby
added
dev tool
Dev tool improvement or update (issue and PR) - release notes section
internal
Ignore this PR in automatically generated release notes - no release notes section
labels
Apr 20, 2024
3 tasks
3 tasks
pyby
added
CI
CI workflow improvement or update (issue and PR) - release notes section
and removed
dev tool
Dev tool improvement or update (issue and PR) - release notes section
labels
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
After #447 implementing non-production environment deployments, adding the AppStore distribution as a production environment deployments is one next step.
Not sure when is useful on GitHub pages for now, it's useful for Jira deployment view.
Proposition is to use the
appStoreAppStatus
lane which is already check the AppStore Connect states. Add an option to manage GitHub production deployments.bundle exec fastlane ios appStoreAppStatus github_deployments:true
Additional documentations:
Description
github_deployments
optional option to the existingappStoreAppStatus
lane. Iftrue
, manage Github production deployments.success
(=READY_FOR_SALE
) is the new state.Checklist
develop
branch for whole tests with nighties, but it's not required.*make quality
passes with a green tick on the last commit.* The project uses Github merge queue feature, which rebases onto the
develop
branch before squashing and merging the PR.