Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github production deployments #462

Merged
merged 14 commits into from
Apr 23, 2024
Merged

Github production deployments #462

merged 14 commits into from
Apr 23, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented Apr 20, 2024

Motivation and Context

After #447 implementing non-production environment deployments, adding the AppStore distribution as a production environment deployments is one next step.

Not sure when is useful on GitHub pages for now, it's useful for Jira deployment view.

Proposition is to use the appStoreAppStatus lane which is already check the AppStore Connect states. Add an option to manage GitHub production deployments.

bundle exec fastlane ios appStoreAppStatus github_deployments:true

Additional documentations:

Description

  • Add github_deployments optional option to the existing appStoreAppStatus lane. If true, manage Github production deployments.
  • Define and implement the workflow between AppStore application version state and GitHub deployment state.
    • For each BUs (5), each platforms (2), work with 1 or 2 versions: current in live, and optional next version.
    • Create or update GH production environments for each BUs and platforms.
    • Create or update GH production deployments, for each tag used in AppStore Connect.
    • Use same Github page build url if success (= READY_FOR_SALE) is the new state.
  • Update documentation "Github environments and deployments".
  • Refactor some ruby codes and try default parameter value.

Checklist

  • The branch should be rebased onto the develop branch for whole tests with nighties, but it's not required.*
  • The code followed the code style as make quality passes with a green tick on the last commit.
  • Remote configuration properties have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • Issues are linked to the PR, if any.

* The project uses Github merge queue feature, which rebases onto the develop branch before squashing and merging the PR.

@pyby pyby added dev tool Dev tool improvement or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section labels Apr 20, 2024
@pyby pyby mentioned this pull request Apr 21, 2024
3 tasks
@pyby pyby marked this pull request as ready for review April 21, 2024 15:30
@pyby pyby added this pull request to the merge queue Apr 23, 2024
Merged via the queue into develop with commit 292af7e Apr 23, 2024
1 check passed
@pyby pyby deleted the feature/production-deployments branch April 23, 2024 15:26
@pyby pyby added CI CI workflow improvement or update (issue and PR) - release notes section and removed dev tool Dev tool improvement or update (issue and PR) - release notes section labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI workflow improvement or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant