Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS song list layout (PLAYRTS-5494) #456

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

pyby
Copy link
Member

@pyby pyby commented Apr 6, 2024

Motivation and Context

A user reported a song title text issue when the song is playing, the artist name could not be readable correctly, when title switch from 1 line to 2 lines on a small-width screen (including an iPad in split view).

IMG_4168

Description

  • Keep the same number of lines for the title, with or without the waveform. No cell height changes when selecting the cell as well.

Checklist

  • The branch should be rebased onto the develop branch for whole tests with nighties, but it's not required.*
  • The code followed the code style as make quality passes with a green tick on the last commit.
  • Remote configuration properties have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • Issues are linked to the PR, if any.

* The project uses Github merge queue feature, which rebases onto the develop branch before squashing and merging the PR.

@pyby pyby added the bug Issue to be fix (issue and PR) - release notes section label Apr 6, 2024
@pyby pyby added this pull request to the merge queue Apr 15, 2024
Merged via the queue into develop with commit 7cd4a24 Apr 15, 2024
2 checks passed
@pyby pyby deleted the feature/fix-song-list-layout branch April 15, 2024 09:12
@pyby pyby changed the title Fix song list layout (PLAYRTS-5494) Fix iOS song list layout (PLAYRTS-5494) May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue to be fix (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant