Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio and subtitle selection to support information (PLAYRTS-5498) #446

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Mar 20, 2024

Motivation and Context

Users recently reported playback issues which could only reproduced with subtitles enabled.

To help us better understand the context associated with a reported issue, this PR adds audio and subtitle selection information to support information that can be sent to us.

Description

Self-explanatory.

Checklist

  • The branch should be rebased onto the develop branch for whole tests with nighties, but it's not required.*
  • The code followed the code style as make quality passes with a green tick on the last commit.
  • Remote configuration properties have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • Issues are linked to the PR, if any.

* The project uses Github merge queue feature, which rebases onto the develop branch before squashing and merging the PR.

@defagos defagos requested a review from pyby March 20, 2024 09:02
@defagos defagos added the improvement Feature or update (issue and PR) - release notes section label Mar 20, 2024
@defagos defagos enabled auto-merge March 20, 2024 09:02
@defagos defagos added this pull request to the merge queue Mar 20, 2024
@defagos defagos removed this pull request from the merge queue due to a manual request Mar 20, 2024
@defagos defagos self-assigned this Mar 20, 2024
@pyby pyby force-pushed the feature/improved-support-information branch from 50144e1 to 53f93f8 Compare April 2, 2024 13:56
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+improved-support-information April 2, 2024 14:00 Inactive
@pyby pyby changed the title Add audio and subtitle selection to support information Add audio and subtitle selection to support information (PLAYRTS-5498) Apr 3, 2024
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+improved-support-information April 4, 2024 19:50 Inactive
@pyby pyby force-pushed the feature/improved-support-information branch from cefc6d7 to ee4d271 Compare April 4, 2024 20:51
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+improved-support-information April 4, 2024 20:53 Inactive
@pyby pyby self-assigned this Apr 4, 2024
@pyby pyby self-requested a review April 4, 2024 22:10
@pyby pyby removed their assignment Apr 5, 2024
@defagos defagos added this pull request to the merge queue Apr 5, 2024
Merged via the queue into develop with commit 445be72 Apr 5, 2024
2 checks passed
@defagos defagos deleted the feature/improved-support-information branch April 5, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants