Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sns topic for grafana alerts #9

Merged
merged 1 commit into from
Nov 26, 2024
Merged

feat: add sns topic for grafana alerts #9

merged 1 commit into from
Nov 26, 2024

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Nov 21, 2024 •
edited
Loading

Description

Resolves #8 by adding an SNS topic for grafana alerts.

Changes Made

  • Exposed SNS as a vpc endpoint.
  • Created the SNS topic.
  • Assigned necessary IAM roles to the Grafana workspace.
  • Added an email subscription to the new topic, the email list can be configured through a variable.

Checklist

  • I have followed the project's style and contribution guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.

@jboix jboix self-assigned this Nov 21, 2024
@jboix jboix requested review from a team, defagos, MGaetan89, waliid, StaehliJ and amtins and removed request for a team November 22, 2024 10:30
@jboix
feat: add sns topic for grafana alerts
4cab7ea 
Resolves #8 by adding an SNS topic for grafana alerts.

Changes made:
- Exposed SNS as a vpc endpoint.
- Created the SNS topic.
- Assigned necessary IAM roles to the Grafana workspace.
- Added an email subscription to the new topic, the email list can be configured through
  a variable.
@jboix jboix force-pushed the feat/sns-topic-grafana branch from 869411b to 4cab7ea Compare November 26, 2024 17:03
@jboix jboix marked this pull request as ready for review November 26, 2024 17:03
@jboix jboix added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 1b169c4 Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

@defagos defagos defagos approved these changes

@waliid waliid Awaiting requested review from waliid

@StaehliJ StaehliJ Awaiting requested review from StaehliJ

@amtins amtins Awaiting requested review from amtins

Assignees

@jboix jboix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SNS Topic for Grafana Alerts
3 participants
@jboix @defagos @MGaetan89