Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initial infrastructure setup for pillarbox monitoring #1

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Oct 7, 2024

Description

This commit introduces the foundational Infrastructure as Code (IaC) setup for the Pillarbox Monitoring system to automate and simplify the deployment of these services.

  • Configures Terraform for managing AWS resources with support for both dev and prod environments.
  • Provides Docker Compose for local development and testing.

Checklist

  • I have followed the project's style and contribution guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.

@jboix jboix self-assigned this Oct 7, 2024
@jboix jboix force-pushed the feat/initial-setup branch 6 times, most recently from ed7b693 to c8cf320 Compare October 9, 2024 12:10
@jboix jboix marked this pull request as ready for review October 9, 2024 12:17
@jboix jboix requested a review from Jefl October 9, 2024 12:17
.gitignore Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
Copy link
Member

@defagos defagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot really provide a good feedback about the configuration itself (not proficient in this kind of stuff myself), I just reported a few things I noticed.

Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first set of comments, I still have some files to check

docker-compose.yml Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
@jboix jboix force-pushed the feat/initial-setup branch 4 times, most recently from 229c313 to 4be2438 Compare October 10, 2024 09:09
@jboix
Copy link
Contributor Author

jboix commented Oct 10, 2024

@MGaetan89 and @defagos I've prepared another PR for the change from qos to monitoring here: SRGSSR/pillarbox-monitoring-transfer#2 Take a look at that so that I can merge this one.

Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but just sharing what I saw: TF files have different formats for assignments.

// `=` are aligned
my_block1 {
  my_var            = true
  my_extra_long_var = 42
}

// `=` are not aligned
my_block2 {
  my_var = true
  my_extra_long_var = 42
}

@jboix jboix force-pushed the feat/initial-setup branch from 4be2438 to b971746 Compare October 10, 2024 11:37
This commit introduces the foundational Infrastructure as Code (IaC) setup for the Pillarbox
Monitoring system to automate and simplify the deployment of these services.

- Configures Terraform for managing AWS resources with support for both dev and prod environments.
- Provides Docker Compose for local development and testing.

Co-authored-by: Samuel Défago <[email protected]>
Co-authored-by: Gaëtan Muller <[email protected]>
@jboix jboix force-pushed the feat/initial-setup branch from b971746 to 487fedb Compare October 10, 2024 11:38
@jboix jboix merged commit 50fccbe into main Oct 10, 2024
1 check passed
@jboix jboix deleted the feat/initial-setup branch November 28, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants