-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add initial infrastructure setup for pillarbox monitoring #1
Conversation
ed7b693
to
c8cf320
Compare
pillarbox-monitoring-grafana/provisioning/dashboards/dashboard.yml
Outdated
Show resolved
Hide resolved
pillarbox-monitoring-terraform/20-pillarbox-monitoring-app/data_transfer_service.tf
Outdated
Show resolved
Hide resolved
pillarbox-monitoring-terraform/20-pillarbox-monitoring-app/data_transfer_service.tf
Outdated
Show resolved
Hide resolved
pillarbox-monitoring-terraform/20-pillarbox-monitoring-app/grafana.tf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot really provide a good feedback about the configuration itself (not proficient in this kind of stuff myself), I just reported a few things I noticed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first set of comments, I still have some files to check
229c313
to
4be2438
Compare
@MGaetan89 and @defagos I've prepared another PR for the change from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, but just sharing what I saw: TF files have different formats for assignments.
// `=` are aligned
my_block1 {
my_var = true
my_extra_long_var = 42
}
// `=` are not aligned
my_block2 {
my_var = true
my_extra_long_var = 42
}
4be2438
to
b971746
Compare
This commit introduces the foundational Infrastructure as Code (IaC) setup for the Pillarbox Monitoring system to automate and simplify the deployment of these services. - Configures Terraform for managing AWS resources with support for both dev and prod environments. - Provides Docker Compose for local development and testing. Co-authored-by: Samuel Défago <[email protected]> Co-authored-by: Gaëtan Muller <[email protected]>
b971746
to
487fedb
Compare
Description
This commit introduces the foundational Infrastructure as Code (IaC) setup for the Pillarbox Monitoring system to automate and simplify the deployment of these services.
Checklist