-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom tracker support #325
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
waliid
approved these changes
Mar 27, 2023
waliid
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR adds support for custom trackers, most notably for analytics or QoS purposes.
Main differences with the PoC implementation
In comparison to our PoC implementation (see #292):
Changes made
Implementation considerations
Source
type was superfluous and could be removed. As a result hePlayer
,PlayerItem
,Asset
andResource
type structure now more closely matches the similarAVPlayer
,AVPlayerItem
,AVAsset
andURL
structure found in AVFoundation.AssetMetadata
protocol has been added to model item metadata. Control center standard metadata is currently the only requirement associated with this protocol.PlayerItem
, where such erasure would have led to friction since@Published
properties cannot appear as is in a protocol.CurrentTracker
class type ensuring that the tracker lifecycle is consistent at all times, most notably if the player is deallocated during playback.Afterword
I updated the dedicated Letterbox idea thread accordingly, as many open questions have now found an answer.
Checklist