Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VMware ClusterType to be iso with netbox-sync #438

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

n-rodriguez
Copy link
Contributor

To ease migration from netbox-sync.

Thank you!

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 16.10%. Comparing base (37defe8) to head (86c05cf).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/source/vmware/vmware_sync.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #438   +/-   ##
=======================================
  Coverage   16.10%   16.10%           
=======================================
  Files          56       56           
  Lines        9195     9195           
=======================================
  Hits         1481     1481           
  Misses       7674     7674           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bl4ko
Copy link
Member

bl4ko commented Jan 25, 2025

thanks

@bl4ko bl4ko merged commit c00c0b4 into SRC-doo:main Jan 25, 2025
6 of 7 checks passed
@n-rodriguez n-rodriguez deleted the wip/fixes branch February 20, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants