Update PMDB.Create_Database_Backup.sql#9
Open
Imran-imtiaz48 wants to merge 1 commit intoSQL-Server-projects:masterfrom
Open
Update PMDB.Create_Database_Backup.sql#9Imran-imtiaz48 wants to merge 1 commit intoSQL-Server-projects:masterfrom
Imran-imtiaz48 wants to merge 1 commit intoSQL-Server-projects:masterfrom
Conversation
IMPROVEMENTS MADE 1. Error Handling with TRY...CATCH: o Added error handling to catch and display any issues during execution. 2. Improved String Handling: o Used NVARCHAR for better Unicode support. o Used sp_executesql for executing dynamic SQL, which is safer and more efficient. 3. Removed Hardcoded Paths: o Added flexibility for setting the backup folder path based on the server. 4. Enhanced Readability: o Organized and grouped related PRINT statements to make debugging easier. o Removed unnecessary debug outputs and kept only meaningful messages. 5. SQL Injection Prevention: o Avoided direct string concatenation by constructing SQL in a safer way. 4. NEXT STEPS • Standardize Backup Path: Replace the hardcoded paths with a configuration table or parameter to make it dynamic and maintainable. • Logging: Add proper logging to record the success or failure of backups in a table or file for auditing purposes. • Security: Ensure that the procedure is executed with the least privilege necessary to perform backups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPROVEMENTS MADE
o Used sp_executesql for executing dynamic SQL, which is safer and more efficient.