expanded on open recent functionality #554
Open
+964
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sebastian-swob
commented
Oct 21, 2024
There was a problem hiding this comment.
Add descriptions for the tests
sebastian-swob
commented
Oct 21, 2024
sebastian-swob
commented
Oct 21, 2024
| for recentProject in _deque(reversed(RecentProjectsHandler.recentProjects)): | ||
| _qtw.QListWidgetItem(str(recentProject), self.listWidget) | ||
|
|
||
| def clickButtonHandler(self, clickedItem): |
There was a problem hiding this comment.
try dictionary
sebastian-swob
commented
Oct 21, 2024
| from trnsysGUI.common import cancelled as _ccl | ||
| from trnsysGUI.diagram import Editor as _de | ||
| from trnsysGUI.storageTank.widget import StorageTank | ||
| from trnsysGUI.constants import UNSAVED_PROGRESS_LOST |
There was a problem hiding this comment.
do constants.UNSAVED_PROGRESS_LOST
sebastian-swob
commented
Oct 21, 2024
| @@ -245,25 +252,18 @@ def shutdown(self) -> None: | |||
| self.editor.shutdown() | |||
|
|
|||
| def newDia(self): | |||
There was a problem hiding this comment.
make more descriptive
sebastian-swob
commented
Oct 21, 2024
| if recentProject != currentProject and recentProject.exists(): | ||
| recentProjectAction = _qtw.QAction(str(recentProject), self) | ||
| self.recentProjectsMenu.addAction(recentProjectAction) | ||
| print("Help me: ", RecentProjectsHandler.recentProjects) |
sebastian-swob
commented
Oct 22, 2024
| e.accept() | ||
| elif ret == _qtw.QMessageBox.Save: | ||
| return | ||
| if ret == _qtw.QMessageBox.Save: | ||
| self.editor.save() |
There was a problem hiding this comment.
Is it reasonable to change this to saveProject?
sebastian-swob
commented
Oct 22, 2024
| @@ -599,16 +591,14 @@ def closeEvent(self, e): | |||
| ret = qmb.exec() | |||
There was a problem hiding this comment.
Change to messagebox please.
sebastian-swob
commented
Oct 22, 2024
sebastian-swob
commented
Oct 22, 2024
sebastian-swob
commented
Oct 22, 2024
|
|
||
|
|
||
| class RecentProjectsHandler: | ||
| recentProjects = list[_pl.Path] |
There was a problem hiding this comment.
typing of Deque
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.