Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#5 create common objects #6

Merged
merged 6 commits into from
Nov 25, 2023
Merged

Conversation

yummygyudon
Copy link
Collaborator

๐Ÿ“ PR Summary

๊ณตํ†ต์ ์œผ๋กœ ์“ฐ์ผ ๊ฐ์ฒด์™€ ๊ณตํ†ต์ ์ธ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ๋ฅผ ์œ„ํ•œ ControllerAdvice ๋ฐ ExceptionHandler ๋ฅผ ๊ตฌ์„ฑํ•ฉ๋‹ˆ๋‹ค.


๐Ÿค” ์–ด๋–ค ์ด์œ ๋กœ ๋ณ€๊ฒฝ๋œ ๋‚ด์šฉ์ธ์ง€

๋น ๋ฅด๊ณ  ํ‘œ์ค€ํ™”๋œ ํ˜‘์—…์„ ์œ„ํ•ด!

๐ŸŒด Works

  • ๊ณ„์ธตํ™” ๋ฐ ํƒ€์ž… ๊ตฌ์ฒดํ™”๋ฅผ ์œ„ํ•ด Error ๋ฐ Success ์ƒ์† ๊ตฌ์กฐ ๊ตฌ์ถ•
  • Exception ๊ณ„์ธตํ™” ๋ฐ ์„ธ๋ถ„ํ™” ๊ธฐ๋ฐ˜ ์ค€๋น„
  • ApiResponse ๊ฐ์ฒด ๊ตฌํ˜„

๐ŸŒต Working Branch

feat/#5-create-common-objects


โ˜ƒ๏ธ Related Issue

closed #5

๐Ÿ™ ๊ฒ€ํ†  ํ˜น์€ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ๋‚จ๊ธฐ๊ณ  ์‹ถ์€ ๋ง

  • ๊ถ๊ธˆํ•œ ์ ์ด๋‚˜ ๊ฐœ์„ ์ ์ด ์žˆ๋‹ค๋ฉด ์–ธ์ œ๋“  ๋ถ€๋‹ด์—†์ด ๋ง์”€ํ•ด์ฃผ์„ธ์š”์˜น~~ ์šฐ๋ฆฌ ๋ชจ๋‘์˜ ์„ฑ์žฅ์„ ์œ„ํ•ด!! ๐Ÿ˜‹

@yummygyudon yummygyudon added โœจFeat ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์ถ”๊ฐ€ ๋™๊ทœ ํ–„๐Ÿน Extra attention is needed labels Nov 24, 2023
@yummygyudon yummygyudon requested a review from kseysh November 24, 2023 18:15
@yummygyudon yummygyudon self-assigned this Nov 24, 2023
@yummygyudon yummygyudon linked an issue Nov 24, 2023 that may be closed by this pull request
7 tasks
@yummygyudon yummygyudon merged commit c53665f into dev Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โœจFeat ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์ถ”๊ฐ€ ๋™๊ทœ ํ–„๐Ÿน Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Create common response dto and base exception/error
1 participant