Test for __has_cpp_attribute before clang-specific feature #1230
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without testing for clang, it could also return true for gcc 14, which implements support for __has_feature() too, resulting in errors due to using clang-specific clang::fallthrough attribute with gcc. Note that we can't just avoid using clang attribute because clang would return true from __has_cpp_attribute(fallthrough) even when not using C++17 but then would give a warning about using C++17 attribute when actually using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make SOCI_HAS_CLANG_FEATURE() really clang-specific, as it could also return true for gcc 14, which implements support for __has_feature() too.
And test for the standard __has_cpp_attribute and use the standard [[fallthrough]] attribute before testing for clang-specific feature and using [[clang::fallthrough]] -- standard attribute should be preferred.
This fixes the build with gcc 14.