Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: more tests, functional tests, replace ava to vitest & fixes #78

Merged
merged 30 commits into from
Nov 30, 2023

Conversation

endes0
Copy link
Member

@endes0 endes0 commented Nov 28, 2023

The main goal of this PR is to add new tests(mostly functional) and fix/refactor the current tests. It also fixes a lot of bugs and discovers new ones (#76 #75).

Closes #35

@endes0 endes0 changed the title test: More tests, functional tests, remplace ava to vitest & fixes test: more tests, functional tests, remplace ava to vitest & fixes Nov 28, 2023
@endes0 endes0 changed the title test: more tests, functional tests, remplace ava to vitest & fixes test: more tests, functional tests, renplace ava to vitest & fixes Nov 28, 2023
@endes0 endes0 changed the title test: more tests, functional tests, renplace ava to vitest & fixes test: more tests, functional tests, replace ava to vitest & fixes Nov 28, 2023
@oxcabe oxcabe self-requested a review November 28, 2023 23:31
Copy link
Member

@oxcabe oxcabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! You should merge the main branch into this one for the CI workflow to pass. I changed it to use yarn, as it was still using npm.

Copy link
Member

@oxcabe oxcabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the changes I am requesting here, we can skip the test to describe/it ones so we can keep advancing with the general refactor.

If we choose to skip those changes, it should still be referenced into a new issue and addressed in the future, where we can either reimplement the tests à la Rust or commit with the describe approach.

package.json Show resolved Hide resolved
src/test/functional/Superescalar/latencies.spec.ts Outdated Show resolved Hide resolved
src/test/functional/Superescalar/latencies.spec.ts Outdated Show resolved Hide resolved
src/test/functional/Superescalar/latencies.spec.ts Outdated Show resolved Hide resolved
src/test/functional/Superescalar/loop.spec.ts Outdated Show resolved Hide resolved
src/test/functional/Superescalar/loop.spec.ts Outdated Show resolved Hide resolved
src/test/functional/Superescalar/newop.spec.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@endes0
Copy link
Member Author

endes0 commented Nov 29, 2023

For the changes I am requesting here, we can skip the test to describe/it ones so we can keep advancing with the general refactor.

If we choose to skip those changes, it should still be referenced into a new issue and addressed in the future, where we can either reimplement the tests à la Rust or commit with the describe approach.

I did not implement the tests in the correct way (with describe/it) as the tests in ava did not use them and I rushed the change from ava to vitest. I prefer to skip those changes at the moment, because I am behind in my plannings. As you suggested, I can open an issue about this.

@endes0 endes0 requested a review from oxcabe November 29, 2023 15:42
src/test/functional/Superescalar/loop.spec.ts Outdated Show resolved Hide resolved
src/test/functional/Superescalar/loop.spec.ts Outdated Show resolved Hide resolved
src/test/functional/Superescalar/loop.spec.ts Outdated Show resolved Hide resolved
src/test/functional/code/bucle.ts Show resolved Hide resolved
@oxcabe oxcabe merged commit 92a2d54 into SIMDE-ULL:main Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register R0 value should not be mutable
2 participants