Renderer: Added camera boundaries to CameraManager and clamping #1682. #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
area: renderer
4 tasks
heinezen
reviewed
Sep 29, 2024
4 tasks
|
@EdvinLndh Are you planning to continue this one soon-ish? |
|
Sorry, I've been out of town for a few weeks, I'll look into it |
heinezen
reviewed
Oct 19, 2024
|
I have converted this into a draft while you work on it. Once you are done, you can set it as ready with the "Ready for review" button above. |
heinezen
requested changes
Oct 22, 2024
|
We are slowly getting there :) |
|
Yes! Thank you for your feedback and patience with me, I'm learning a lot! 😁 |
|
Btw if you think you solved something I mentioned, you can press the "Resolve coonversation" button to mark it as completed. Then I know what you are still working on. |
heinezen
requested changes
Oct 31, 2024
|
I would check this a final time now for merging if that's okay :) |
heinezen
requested changes
Nov 2, 2024
…e camera movement.
… of smallest positive value.
heinezen
force-pushed
the
add_camera_boundaries
branch
from
e050d27 to
179e1ad
Compare
heinezen
previously approved these changes
Nov 7, 2024
heinezen
approved these changes
Nov 7, 2024
|
It's merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Camera boundaries are set using constants for now, will probably look into setting the boundaries dynamically soon. #1682