Revised vapor composition constraints fix ZeroDivisionError when gdp.hull reformulation is applied #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hull reformulation is applied
|
As long as there are no errors, this PR is ready to be merged. @bernalde |
bernalde
requested changes
Aug 14, 2024
| @@ -245,7 +243,7 @@ def build_model(): | |||
| for comp in m.comp: | |||
| m.dHvap[comp] = dHvapb[comp] / m.Hscale | |||
|
|
|||
| ## Heat capacity calculation for liquid and vapor phases using Ruczika-D method for each component in the feed, section, and tray | |||
| ## Heat capacity calculation for liquid and vapor phases for each component in the feed, section, and tray | |||
There was a problem hiding this comment.
Why remove the comment on the method? Is that method not used? If it is used, leave the comment and add a reference
| m.prop[comp, 'TC'] / m.Tup, | ||
| m.prop[comp, 'TC'] / m.Tlo, | ||
| ), # (0, None), | ||
| initialize=lambda m, sec, tray, comp: m.T0[sec, tray] / m.Tlo, |
There was a problem hiding this comment.
I like this way of defining bounds and initializations!
| m.prop[comp, 'TC'] | ||
| / m.T[1, n_tray] | ||
| m.Tr[1, n_tray, comp] | ||
| # m.prop[comp, 'TC'] |
There was a problem hiding this comment.
Why leave these lines here? If the code works, remove the comments as they become confusing
| @@ -1472,7 +1502,7 @@ def bottom_vapor_composition(disj, comp): | |||
| ) | |||
| ) | |||
| ) | |||
| / m.P[1, n_tray] | |||
| # / m.P[1, n_tray] | |||
There was a problem hiding this comment.
Remove comment as pressure multiplied in the other side of the equality
| The constraint equation to calculate the temperature term for the top section vapor composition. | ||
| """ | ||
| return m.Tr[4, n_tray, comp] * m.T[4, n_tray] == m.prop[comp, 'TC'] | ||
|
|
||
| @disj.Constraint(m.comp, doc="Top scetion 4 vapor composition") |
ZedongPeng
force-pushed
the
tristantc/issue44
branch
from
f798d9d
to
2838304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the ZeroDivisionError when gdp.hull reformulation is applied in the Kaibel instance.
File:
gdplib/kaibel/kaibel_solve_gdp.py