Added the small batch on the gdplib #10
Conversation
|
I will only want us to work on this PR once all the other examples from GDPLib are updated to the latest version of Pyomo. |
There was a problem hiding this comment.
Since this is the first PR with our own newly contributed models, we need to be way more strict with the formatting. Debugging comments are no longer allowed. Only functions relevant to the model should be included (not the solution method). THe example itself is not the one found in Kocis and Grossmann, it is a simplification made for the LDSDA paper, so update the references.
There was a problem hiding this comment.
This looks good, @ZedongPeng if this code already runs with your LDSDA implementation, feel free to merge
|
Replace gam by gamma as it is the ration of Cp and Cv |
|
The spelling check is failing because of the hda files. Besides the spelling check, there are no issues with the gdp_small_batch.py and I strongly believe this is ready to be merged. And I am not sure whether we have to discuss for the format of HDA files, There are two gammas one is the gamma for the ratio of the Cv and Cp the other is the decision variables related to the absorption process. |
gdplib/small_batch/README.md
Outdated
|
|
||
| [1] Kocis, G. R.; Grossmann, I. E. Global Optimization of Nonconvex Mixed-Integer Nonlinear Programming (MINLP) Problems in Process Synthesis. Ind. Eng. Chem. Res. 1988, 27 (8), 1407-1421. https://doi.org/10.1021/ie00080a013 | ||
|
|
||
| [2] Ovalle, D., Liñán, D. A., Lee, A., Gómez, J. M., Ricardez-Sandoval, L., Grossmann, I. E., & Neira, D. E. B. (2024). Logic-Based Discrete-Steepest Descent: A Solution Method for Process Synthesis Generalized Disjunctive Programs. arXiv preprint arXiv:2405.05358. https://doi.org/10.48550/arXiv.2405.05358 |
There was a problem hiding this comment.
My last name to be cited is Bernal Neira, not Neira
Added the gdp_small_batch.py on the gdp library.