Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep timer #26

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

shadmanadman
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • [0] Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Related Issues & Documents

Description

A sleep timer is always a good option for a music player. I'm happy to be participating in this cool KMP project.

Code Changes

  • The big change is that I created a CountDownTimer expect/actaul function to listen for the timer.
  • Another change is the UI for selecting a time to audio to be stopped. its a small modal bottom sheet.
  • Also some small changes in ChartDetails.kt to show an icon for sleep timer and managing to get the MediaPlayerController also in this screen to stop the audio when timer is finished.
  • Some upgrading in gradle and AGP

Screenshots, Recordings

untitled.webm

@SEAbdulbasit
Copy link
Owner

Hi @shadmanadman thank you so much for this feature. I will review that shortly.

@EdvaldoCariege
Copy link

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants