Subst cleanups#4874
Open
mwichmann wants to merge 1 commit into
Open
Conversation
Changes to doctrings and typing in function signatures. scons_subst and scons_subst_list now check if the ovverides arg is None. Small tweak to ActionTests is to make sure it actually calls scons_subst and scons_subst_list with overrides as a dict (previously it defaulted to a bool). Signed-off-by: Mats Wichmann <mats@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to doctrings and typing in function signatures.
scons_substandscons_subst_listnow check if the overrides arg is None.Small tweak to
ActionTestsis to make sure it actually callsscons_substandscons_subst_listwith overrides as a dict (previously it defaulted to a bool).No functionality changes. This the the rest of the work split out from PR #4869.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).