Builder method docs: sources and targets #4766
Conversation
doc/man/scons.xml
Outdated
|
|
||
| <note> | ||
| <para> | ||
| On Windows, DOS paths may beging with a volume or drive letter |
There was a problem hiding this comment.
Sigh. I proofread several time to avoid that kinda thing.
doc/man/scons.xml
Outdated
| if the volume specifier is present, | ||
| resolution starts at the root of the specified drive for absolute paths | ||
| and the current directory on the specified drive for relative paths. | ||
| The combination of a drive letter different from the |
There was a problem hiding this comment.
Can you clarify this? I'm not sure I understand.
so d:....\xyz ?
There was a problem hiding this comment.
If you're working in C:/users/mats/project, and you give a path D:/other/foo, that's clear. If you give D:foo it isn't, because we don't know what Windows' idea of the current directory on D is. Consider:
C:\Users\mats\project> D:
D:\>cd github
D:\github>
C:
C:\Users\mats\project>sconsBecuase I'd never done anything in the D drive previously, the "current directory" was \, as seen when switching to it. I change directory. Switch back to C, which remembered my past current directory there. It's like pushd/popd, kinda. Now, from my work area I run SCons. It (or rather it's parent Python) has no earthly idea that Windows behind the scenes is remembering for me that the "current directory" on D is \github.
There was a problem hiding this comment.
Can you expand the explanation, maybe include the above?
|
LGTM minus 2 comments, resolve those and I'll merge away.. |
More harvesting of ideas from withdawn PR revising the manpage Builder Method section. This rewords the description of acceptable forms for the source and target arguments. Review of SCons#4671 indicated that removing details the topic of absolute and relative paths unwanted, so this restores and expands on that section. Signed-off-by: Mats Wichmann <[email protected]>
Signed-off-by: Mats Wichmann <[email protected]>
mwichmann
force-pushed
the
doc/builders-3
branch
from
b76b2b9 to
3bec232
Compare
More harvesting of ideas from withdawn PR revising the manpage Builder Method section. This rewords the description of acceptable forms for the source and target arguments. Review of #4671 indicated that removing details the topic of absolute and relative paths unwanted, so this restores and expands on that section.
This is a doc-only change. There is no additional information to add to previous unreleased CHANGES and RELEASE files. If this change is deferred to the next release cycle, those files will receive fresh updates.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).