-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalized search_mesh that takes a functor to execute at element boundary or destination #130
Generalized search_mesh that takes a functor to execute at element boundary or destination #130
Conversation
Thank you. Does this support 2d and/or 3d meshes? Are there any tests available? |
Yes, as the original |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together. There are a few minor issues that need to be resolved to clean up the interfaces so we are not requiring implementation specific data to be passed around, but this is looking very good.
Thanks!
suggested changes made: removed the requireIntersection flag from the () operator, kept set_new_element in particle search rather than calling in the function, side_is_exposed array computed once during the construction and saved there instead of computing it every functor call.
I have added a brief description for renamed |
There shouldn't be any merge conflict, but it's showing an "empty" line coming from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you.
This new
particle_search
method allows passing a functor that takes all the necessary objects it wants to handle. It is run every time the particle reaches an element boundary or its destination i.e. after every call offind_exit_face
. It will allow various things including handling different boundary conditions, recording information, etc.