Use Kokkos sort_by_key for stable sorting #129
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omega_h currently relies on a set of vendor specific sorting routines captured in the
parallel_sort()function. This pull request replaces the vendor specific sorting routines with Kokkos' newsort_by_key()routine, which provides a stable sorting routine utilizing the same comparator as theparallel_sort()function. A compile time optionOMEGA_H_FORCE_KOKKOS_SORTis enabled by default and forces the use of the new sorting routine. It can be disabled to fall back toparallel_sort().