Fix #2448 - Some distance transforms cause excessive iterations when snapping to surface #2449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…snapping to surface Our distance transforms are usually not true distance transforms. The blue/smoothing breaks some assumptions, e.g. that the gradient magnitude should be 1.0 everywhere. This approach uses damping and reduced max iterations,
…onstraints When gradient magnitude is very weak (< 0.5), cap the step size by the distance value to prevent taking unreasonably large steps. This handles pathological cases in smoothed distance fields where weak gradients can cause steps orders of magnitude larger than the distance to the surface and exceed the narrow band.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our distance transforms are usually not true distance transforms. The blue/smoothing breaks some assumptions, e.g. that the gradient magnitude should be 1.0 everywhere.
This approach uses damping and reduced max iterations,