Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover UI testing #441

Merged
merged 13 commits into from
Mar 31, 2024
Merged

Discover UI testing #441

merged 13 commits into from
Mar 31, 2024

Conversation

Jackson-Williams-15
Copy link
Contributor

This tests the discover post and user searching, filters, pagination, and post card interacivity + signing in to join the post and leaving the post then logging out. The sign up test fails, but the other tests still pass. @epadams said he'll go back and update the "create, sign in, log out" test.
image

@Jackson-Williams-15 Jackson-Williams-15 linked an issue Mar 26, 2024 that may be closed by this pull request
Discover UI Testing #365
Closed
6 tasks
@evan-scales evan-scales requested a review from epadams March 26, 2024 21:41
epadams
epadams previously approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@epadams epadams left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, I think we should go ahead and test Create.jsx before merging this though, take a look at #445 and we can also discuss with the rest of the group how we should set up the tests going forward

@epadams epadams mentioned this pull request Mar 27, 2024
Closed
3 tasks
@epadams epadams marked this pull request as draft March 31, 2024 22:26
@epadams epadams marked this pull request as ready for review March 31, 2024 22:26
epadams
epadams approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@epadams epadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@epadams epadams merged commit c3bc51b into main Mar 31, 2024
2 checks passed
@epadams epadams deleted the DiscoverUiTesting branch March 31, 2024 22:38
@Jackson-Williams-15 Jackson-Williams-15 mentioned this pull request Mar 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epadams epadams epadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discover UI Testing
2 participants
@Jackson-Williams-15 @epadams