Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPA Discover users sorting #436

Merged
merged 8 commits into from
Mar 31, 2024
Merged

SPA Discover users sorting #436

merged 8 commits into from
Mar 31, 2024

Conversation

epadams
Copy link
Contributor

@epadams epadams commented Mar 25, 2024

  • Started work on supporting sorting users
    • Component displays, API should be called correctly but the cards aren't sorting for some reason
  • Added option to sort by number of players in a post (already present in API, wasn't available in front end)

@evan-scales @jbytes1027 I'm also thinking about adding more options to the UserSortType in Sorting.cs, most probably account age and user age. Wondering what y'alls opinion is since we only have ~1 week left or if other issues should be worked on. Seems like we have all issues for RC1 assigned but there might be other small features we want to implement or general UX improvements.

@epadams epadams self-assigned this Mar 25, 2024
@epadams epadams linked an issue Mar 25, 2024 that may be closed by this pull request
@evan-scales
Copy link
Collaborator

I say go for it for adding more sort options for users. Let me know if you need any help with that

@epadams epadams marked this pull request as ready for review March 31, 2024 19:34
@evan-scales evan-scales marked this pull request as draft March 31, 2024 21:37
@evan-scales evan-scales marked this pull request as ready for review March 31, 2024 21:37
@evan-scales evan-scales merged commit 4ef6fe1 into main Mar 31, 2024
2 checks passed
@evan-scales evan-scales deleted the 218 branch March 31, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPA Discover users sorting
2 participants