Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search button #435

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Add search button #435

merged 3 commits into from
Mar 25, 2024

Conversation

epadams
Copy link
Contributor

@epadams epadams commented Mar 24, 2024

  • Adds search button to both Discover and Social (reusable component)
  • Removes unused useEffect()

I know @evan-scales said in #283 that he would prefer having a dedicated button that says "Search" rather than a hourglass but I personally think this is cleaner/sleeker looking and also easier to work with.

@epadams epadams linked an issue Mar 24, 2024 that may be closed by this pull request
@epadams
Copy link
Contributor Author

epadams commented Mar 24, 2024

Didn't mean to add an updated package-lock.json to this PR but I think it bumps dependencies anyways, if you want/need to me remove it let me know.

@epadams epadams self-assigned this Mar 25, 2024
@epadams epadams mentioned this pull request Mar 25, 2024
@evan-scales evan-scales marked this pull request as draft March 25, 2024 20:28
@evan-scales evan-scales marked this pull request as ready for review March 25, 2024 20:28
@evan-scales evan-scales merged commit 00661d4 into main Mar 25, 2024
2 checks passed
@evan-scales evan-scales deleted the 283 branch March 25, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add submit search button
2 participants