Make integrated build #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndency management Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
- Add chapel as external submodule Signed-off-by: Shreyas Atre <[email protected]>
- Remove frontend directory which is not needed anymore Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
- Also add chapel 1.33.0 patch Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
- Between some versions of chapel while they were trying
their new frontend compiler next, they restricted domains
and array parsing in some way.
- Previously var: data [{1..5}] real; was well defined
however, var: data [1..5] real; was allowed or to me at least,
it is a hint that it was discouraged.
- When I tried our old implementation, i see that we enter the
domain node before we enter a range node. With frontend after
release 1.25.0 instead of domain node for 1..5 we enter
directly into the range node.
- Ref: chapel-lang/chapel#19187
Signed-off-by: Shreyas Atre <[email protected]>
- Modify the benchmark.py script to compile generated chapel code Signed-off-by: Shreyas Atre <[email protected]>
- 1 + (i-1 + nx) % nx is correctly done to 1 + ( ( ( i - 1 ) + nx ) % nx ) - However: d[i] + dt*k/(dx*dx)*(d[i+1] + d[i-1] - 2*d[i]) is done as: d(i) + ( ( ( dt * k ) / ( dx * dx ) ) * ( ( d(1 + i) + d(1 - i) ) - ( 2 * d(i) ) ) ) - This commit checks if both the expressions are not binary expressions it parses the arguments in order Signed-off-by: Shreyas Atre <[email protected]>
Signed-off-by: Shreyas Atre <[email protected]>
Authored-by: Hartmut Kaiser <[email protected]> Signed-off-by: Shreyas Atre <[email protected]>
* Adding specialization for Array<T, Domain<1>> * Adding specializations for iteration of simple ranges, domains, and arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.