Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-side-navigation): add navigation groups #8261

Merged
merged 65 commits into from
Mar 15, 2024
Merged

Conversation

TeodorTaushanov
Copy link
Member

No description provided.

Copy link
Member

@GerganaKremenska GerganaKremenska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When collapsed is false, SideNavigation conatiner padding: 1.5rem 0.75rem 0.75rem 0.75rem;

  2. Should space on group, expand it and collapse it?

packages/fiori/src/SideNavigationSubItem.hbs Show resolved Hide resolved
@TeodorTaushanov
Copy link
Member Author

  1. When collapsed is false, SideNavigation conatiner padding: 1.5rem 0.75rem 0.75rem 0.75rem;
  2. Should space on group, expand it and collapse it?
  1. From the spec
  • Desktop Specification (Compact) - padding: 1.5rem 0.75rem 0.75rem 0.75rem;
  • Tablet Specification (Cozy) - padding: 0.5rem;
  1. Collapse/Expand via Space and Enter key is removed.

@TeodorTaushanov
Copy link
Member Author

When ui5-side-navigation-group or ui5-side-navigation-item with subitem children has the disabled property set, it shouldn't be able to be pressed or selected. Currently, disabled group or parent items are not focusable/in the tab chain, but they can still be pressed and trigger their expand/collapse. Instead, such items/groups should behave as in ui5 - making all their child items disabled as well and should not be interactive (see "Restricted" group in this sample).

This should be discussed with the interaction designers.

@TeodorTaushanov
Copy link
Member Author

When ui5-side-navigation-group or ui5-side-navigation-item with subitem children has the disabled property set, it shouldn't be able to be pressed or selected. Currently, disabled group or parent items are not focusable/in the tab chain, but they can still be pressed and trigger their expand/collapse. Instead, such items/groups should behave as in ui5 - making all their child items disabled as well and should not be interactive (see "Restricted" group in this sample).

This should be discussed with the interaction designers.

The "disabled behavior" will be fixed with another PR.

packages/fiori/src/SideNavigationGroup.ts Outdated Show resolved Hide resolved
packages/fiori/src/SideNavigationGroup.ts Outdated Show resolved Hide resolved
packages/fiori/src/SideNavigationSelectableItemBase.ts Outdated Show resolved Hide resolved
packages/fiori/src/SideNavigationSubItem.ts Outdated Show resolved Hide resolved
packages/fiori/test/pages/SideNavigationWithGroups.html Outdated Show resolved Hide resolved
@BorisDafov
Copy link

I approve the change from UA perspective....

@dimovpetar dimovpetar merged commit 8678dc0 into main Mar 15, 2024
9 checks passed
@dimovpetar dimovpetar deleted the sidenav_groups branch March 15, 2024 14:08
nnaydenow pushed a commit that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants