Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cem enhancements #8135

Merged
merged 2 commits into from
Jan 18, 2024
Merged

chore: cem enhancements #8135

merged 2 commits into from
Jan 18, 2024
+1,194 −1,534

Conversation

nnaydenow
Copy link
Contributor

@nnaydenow nnaydenow commented Jan 18, 2024 •
edited
Loading

  • Module’s path of superclass to be relative to the package from which it comes
  • Add missing JSDoc tags for MultiComboBoxGroupItem / TableGroupRow
  • Fix type definitions for internal and external manifests
  • Enhance event decorator by making it generic. Check the details object with the type provided to the generic (every key described in the type should have respective key in the detail object)

@nnaydenow nnaydenow marked this pull request as ready for review January 18, 2024 09:47
@nnaydenow nnaydenow merged commit c00c425 into main Jan 18, 2024
8 checks passed
@nnaydenow nnaydenow deleted the cem-enhancements branch January 18, 2024 14:51
ilhan007 pushed a commit that referenced this pull request Jan 19, 2024
@nnaydenow @ilhan007
chore: cem enhancements (#8135)
cc9709c 
* chore: cem enhancements

* chore: fix internal type definitions

---------

Co-authored-by: Nayden Naydenov <[email protected]>
ilhan007 pushed a commit that referenced this pull request Jan 25, 2024
@nnaydenow @ilhan007
chore: cem enhancements (#8135)
d78078b 
* chore: cem enhancements

* chore: fix internal type definitions

---------

Co-authored-by: Nayden Naydenov <[email protected]>
tsanislavgatev pushed a commit that referenced this pull request Feb 20, 2024
@nnaydenow @tsanislavgatev
chore: cem enhancements (#8135)
87c2c09 
* chore: cem enhancements

* chore: fix internal type definitions

---------

Co-authored-by: Nayden Naydenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev vladitasev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnaydenow @ilhan007 @vladitasev