fix(ui5-menu): fix runtime js error on getElementById call
#8021
+36
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds a check to guarantee getElementById is called only if existing
1 task
nnaydenow
approved these changes
Dec 19, 2023
pskelin
approved these changes
Dec 19, 2023
PetyaMarkovaBogdanova
pushed a commit
that referenced
this pull request
Jan 17, 2024
The PR adds a check to guarantee getElementById is called only if existing, e.g. the Menu is still part of the DOM tree and has not been removed in-between. The test pages changes are not related to the change, but we have noticed that the used CSS classes "samples-margin", "header" are missing and they are not doing anything. In addition, h tags have been replaced by ui5-title, so that the texts are readable in HC themes (otherwise you get dark texts on dark background). Fixes: #8017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a check to guarantee
getElementByIdis called only if existing, e.g. the Menu is still part of the DOM tree and has not been removed in-between.The test pages changes are not related to the change, but we have noticed that the used CSS classes "samples-margin", "header" are missing and they are not doing anything. In addition,
htags have been replaced byui5-title, so that the texts are readable in HC themes (otherwise you get dark texts on dark background)Note: Writing test would be tricky as we need to mimic delayed DOM removal where the delay is not known, but it should be fine as the change only makes the code safer.
Fixes: #8017