Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-panel): improve header visualization #7906

Merged
merged 1 commit into from
Nov 26, 2023
+12 −22
Merged

fix(ui5-panel): improve header visualization #7906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/main/src/themes/Panel.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
align-items: center;
flex-shrink: 0;
width: var(--_ui5_panel_button_root_width);
height: var(--_ui5_panel_button_root_width);
height: var(--_ui5_panel_button_root_height);
padding: var(--_ui5_panel_header_button_wrapper_padding);
box-sizing: border-box;
}
Expand Down
6 changes: 4 additions & 2 deletions packages/main/src/themes/base/Panel-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
:root {
--_ui5_panel_focus_border: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--sapContent_FocusColor);
--_ui5_panel_button_root_width: 3rem;
--_ui5_panel_header_height: 2.75rem;
--_ui5_panel_button_root_width: 2.75rem;
--_ui5_panel_button_root_height: 2.75rem;
--_ui5_panel_border_radius: 0px;
--_ui5_panel_border_radius_expanded: 0;
--_ui5_panel_default_header_border: none;
Expand All @@ -17,5 +19,5 @@
[data-ui5-compact-size],
.ui5-content-density-compact,
.sapUiSizeCompact {
--_ui5_panel_header_button_wrapper_padding: .5625rem .375rem;
--_ui5_panel_header_button_wrapper_padding: .1875rem .25rem;
}
7 changes: 3 additions & 4 deletions packages/main/src/themes/base/sizes-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,6 @@
/* TextArea */
--_ui5_textarea_margin: .25rem 0;

/* Panel */
--_ui5_panel_header_height: 2.75rem;

/* Radio Button */
--_ui5_radio_button_height: 2.75rem;
--_ui5_radio_button_label_side_padding: .875rem;
Expand Down Expand Up @@ -248,7 +245,9 @@

--_ui5_month_picker_item_height: 2rem;
--_ui5_year_picker_item_height: 2rem;
--_ui5_panel_header_height: 2.5rem;
--_ui5_panel_header_height: 2rem;
--_ui5_panel_button_root_height: 2rem;
--_ui5_panel_button_root_width: 2.5rem;

--_ui5_token_height: 1.25rem;
--_ui5_token_right_margin: 0.25rem;
Expand Down
2 changes: 2 additions & 0 deletions packages/main/src/themes/sap_belize/Panel-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
:root {
--_ui5_panel_header_padding_right: 1rem;
--_ui5_panel_header_height: 3rem;
--_ui5_panel_button_root_width: 3rem;
--_ui5_panel_button_root_height: 3rem;
}

[data-ui5-compact-size],
Expand Down
5 changes: 0 additions & 5 deletions packages/main/src/themes/sap_fiori_3/Panel-parameters.css
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/main/src/themes/sap_fiori_3/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
@import "../base/Menu-parameters.css";
@import "./MonthPicker-parameters.css";
@import "../base/MessageStrip-parameters.css";
@import "./Panel-parameters.css";
@import "../base/Panel-parameters.css";
@import "../base/Popover-parameters.css";
@import "../base/PopupsCommon-parameters.css";
@import "../base/ProgressIndicator-parameters.css";
Expand Down
5 changes: 0 additions & 5 deletions packages/main/src/themes/sap_fiori_3_dark/Panel-parameters.css
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/main/src/themes/sap_fiori_3_dark/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
@import "../base/Menu-parameters.css";
@import "./MonthPicker-parameters.css";
@import "../base/MessageStrip-parameters.css";
@import "./Panel-parameters.css";
@import "../base/Panel-parameters.css";
@import "../base/Popover-parameters.css";
@import "../base/PopupsCommon-parameters.css";
@import "../base/ProgressIndicator-parameters.css";
Expand Down
1 change: 0 additions & 1 deletion packages/main/src/themes/sap_horizon/Panel-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
@import "../base/Panel-parameters.css";

:root {
--_ui5_panel_button_root_width: 2.75rem;
--_ui5_panel_border_radius: var(--sapElement_BorderCornerRadius);
--_ui5_panel_border_bottom: none;
--_ui5_panel_default_header_border: 0.0625rem solid var(--sapGroup_TitleBorderColor);
Expand Down
1 change: 0 additions & 1 deletion packages/main/src/themes/sap_horizon_dark/Panel-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
@import "../base/Panel-parameters.css";

:root {
--_ui5_panel_button_root_width: 2.75rem;
--_ui5_panel_border_radius: var(--sapElement_BorderCornerRadius);
--_ui5_panel_border_bottom: none;
--_ui5_panel_default_header_border: 0.0625rem solid var(--sapGroup_TitleBorderColor);
Expand Down
1 change: 0 additions & 1 deletion packages/main/src/themes/sap_horizon_hcw/Panel-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

:root {
--_ui5_panel_focus_border: 0.125rem dotted var(--sapContent_FocusColor);
--_ui5_panel_button_root_width: 2.75rem;
--_ui5_panel_default_header_border: 0.0625rem solid var(--sapGroup_TitleBorderColor);
--_ui5_panel_outline_offset: -0.125rem;
--_ui5_panel_icon_color: var(--sapButton_Lite_TextColor);
Expand Down