feat: cloned property to the slot decorator #7882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cloned` property should be set to true if the content of the slot is being cloned to the static area. Common example is the valueStateMessage. FIXES: #7681
MapTo0
requested review from
ndeshev,
elenastoyanovaa,
ilhan007,
vladitasev,
ivoplashkov,
nnaydenow and
niyap
vladitasev
approved these changes
Nov 28, 2023
|
Looks good, let's merge this without documenting it officially for developers. in 2024 with the adoptio of the |
PetyaMarkovaBogdanova
pushed a commit
that referenced
this pull request
Dec 5, 2023
`cloned` property should be set to true if the content of the slot is being cloned to the static area. Common example is the valueStateMessage. FIXES: #7681
nnaydenow
added a commit
that referenced
this pull request
Jul 2, 2024
The `cloned` field of `@slot` decorator was introduced to invalidate component slot content was cloned to static area. #7882 Now, when the Popover API is integrated in all of the components, the field is obsolete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clonedproperty should be set to true if the content of the slot is being cloned to the static area. Common example is the valueStateMessage.FIXES: #7681