feat(ui5-dynamic-page): Snapping header #7875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(ui5-dialog): fixed background and shadow when ui5-bar is used inside ui5-dalog fixes: #7418 --------- Co-authored-by: Siyana Todorova <[email protected]>
This update includes the updated theme parameters. See https://github.com/SAP/theming-base-content/releases/tag/11.6.8
* chore: simplify css * chore: finish css changes * fix(ui5-segmented-button): add rtl parameters * fix(ui5-segmented-button): change rtl parameters --------- Co-authored-by: Nayden Naydenov <[email protected]> Co-authored-by: ilhan007 <[email protected]> Co-authored-by: hinzzx <[email protected]> Co-authored-by: Stoyan <[email protected]>
…add wrapping in suggestions and n-more (#7509) * feat(ui5-combobox): poc add wrapping in suggestions and n-more * feat(ui5-combo-box,ui5-multi-combo-box,ui5-input,ui5-multi-input): poc add wrapping suggest/n-more * feat(ui5-combobox, ui5-multi-combo-box, ui5-input, ui5-multi-input): update testing examples * feat(ui5-combobox, ui5-multi-combo-box, ui5-input, ui5-multi-input): add storybook samples * feat(ui5-combobox, ui5-multi-combo-box, ui5-input, ui5-multi-input): update * feat(ui5-combobox, ui5-multi-combo-box, ui5-input, ui5-multi-input): update * feat(ui5-combobox, ui5-multi-combo-box, ui5-input, ui5-multi-input): update comments
Co-authored-by: Nayden Naydenov <[email protected]>
chore: translation delivery Change-Id: I8bae3c3918dc0a092e5bae721540300dfec3d940
In order to fix the visual design in all themes, we had to introduce an alternate CSS variable. This was added because in Horizon themes for example, for the Text and Graphical Switch, the variable --_ui5_switch_text_inactive_left needs to have a different value for each of the styles in order to be properly aligned.
*Bar Cleared the JSDoc enums; Changed the story name to -> Basic *Button Cleared JSDoc enums; Remove redunant Storybook samples; *DatePicker Cleared JSDoc enums; *DynamicSideContent Added custom styling to the native HTML tags as changing the themes wasn't updating the content. For example on Dark themes like Evening Horizon, both the background and the text would appear dark, which led to poor user experience; *FileUploader Cleared JSDoc enums Moved the Custom FileUploader sample to lower position, because we do not encourage using non-focusable elements; *Menu Fixed wrong property name headerText -> header-text because it wasnt showing on Mobile Devices; Changed sample name -> Basic with Header Text -> Basic *SplitButton Cleared JSDoc enums; Remove redunant Storybook samples; *StepInput Cleared JSDoc enums; Wrapped the main story component in the Storybook in a div with max-width: 13rem, due to component being stretched to the whole page, causing poor user experience; Simplified and removed redunant Storybook samples; *Switch Remove redunant Storybook samples; Reduced the Textual Switch samples because we do not encourage using Text in our switch component; *ToggleButton Enhance samples;
… improve samples names (#7588)
feat(ui5-button): remove box shadow
Rework on the Split Button visual design in order to be complient with VD Spec in all themes and rtl direction as well.
Co-authored-by: Elena Stoyanova <[email protected]>
fix(ui5-input): adjust icon's size
* fix(ui5-flexible-column-layout): wrong focus fixed * fix(ui5-breadcrumbs): infinite rerendering fixed --------- Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
With this pull request a mobile input functionality is being added to the TimePicker. On mobile devices (phones), the manual input of the time is not allowed in the component's input field, but separate popover is opened. In this popover all of te input fields for hours/minutes/seconds are of numeric type which allows displaying of pure numeric keyboard. This will ease input of the desired time. Also, optimizations are made in order to reduce codebase as there were similar functionalities used both by TimeSelectionClocks and TimeSelectionInputs private components. Tests are added and some are modified because of oprimization.
* docs(playground): enhance editing of custom typeproperties Related to: #7284 Problem: Some components have properties of custom types that extend sap.ui.webc.base.types.DataType. Storybook allows editing the values of those properies in the Controls addon, but by default storybook allows to edit them via controls of type object. However, in most cases, the more suitable control for editing those values would be of type text or number. Solution: Further customized the story settings to specify the expected control type. To handle the issue globally, added that logic to the existing script that sets control types based on property type. * docs(playground): utilize native Array.prototype.includes function
* refactor(ui5-tree): remove unnecessary code * refactor(ui5-tree): fix comment * refactor(ui5-tree): remove unnecessary parameters
* chore: stable ui5-menu tests * chore: remove only keyword --------- Co-authored-by: Nayden Naydenov <[email protected]>
ding these tags to the form related "value" property, used by the ui5-webc-ngx wrappers to properly generate the required value accessors so the ui5-webc-ngx wrappers work in Angular reactive forms.
The angular tutorial has been update to demonstrate both UI5 Web Components and UI5 Web Components for Angular usage. We no longer recommend Origami, instead we added a sample how to build Form and make use of two-way data binding via the UI5 Web Components for Angular wrappers.
…es/fiori (#7864) build(deps-dev): bump chromedriver in /packages/fiori Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 117.0.3 to 119.0.1. - [Commits](giggio/node-chromedriver@117.0.3...119.0.1) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…es/base (#7863) build(deps-dev): bump chromedriver in /packages/base Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 117.0.3 to 119.0.1. - [Commits](giggio/node-chromedriver@117.0.3...119.0.1) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…es/main (#7861) build(deps-dev): bump chromedriver in /packages/main Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 117.0.3 to 119.0.1. - [Commits](giggio/node-chromedriver@117.0.3...119.0.1) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…es/localization (#7862) build(deps-dev): bump chromedriver in /packages/localization Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 117.0.3 to 119.0.1. - [Commits](giggio/node-chromedriver@117.0.3...119.0.1) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [axios](https://github.com/axios/axios) from 1.4.0 to 1.6.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.4.0...v1.6.1) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* docs: features documentation * chore: remove empty row from table --------- Co-authored-by: Nayden Naydenov <[email protected]>
Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 117.0.3 to 119.0.1. - [Commits](giggio/node-chromedriver@117.0.3...119.0.1) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[INTERNAL] Translation delivery: commit by LX Lab Change-Id: Ib043d352c5567d221a5256e3f4eb89298407f898
…dynamic-page-petya
packages/fiori/src/DynamicPage.hbs
Outdated
Comment on lines
7
to
12
| <ui5-dynamic-page-header-actions | ||
| ?snapped="{{headerSnapped}}" | ||
| ?pinned="{{headerPinned}}" | ||
| @ui5-expand-button-click={{onExpandClick}} | ||
| @ui5-pin-button-click={{onPinClick}} | ||
| ></ui5-dynamic-page-header-actions> |
There was a problem hiding this comment.
We can extract the following code using the inline annotation an reuse it accross the different areas:
...
{{#unless headerSnapped}}
<slot name="headerArea"></slot>
{{> expandPinActions}}
{{/unless}}
...
{{#*inline "expandPinActions"}}
<ui5-dynamic-page-header-actions
?snapped="{{headerSnapped}}"
?pinned="{{headerPinned}}"
@ui5-expand-button-click={{onExpandClick}}
@ui5-pin-button-click={{onPinClick}}
></ui5-dynamic-page-header-actions>
{{/inline}}
|
Also a minor visual issue is that the expand and pin button are missing the lines on the left and the right sides:
|
PetyaMarkovaBogdanova
force-pushed
the
dynamic-page-petya
branch
from
551a290
to
e07c78c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapping header functionality with Header moving in and out of the sticky area, to get more real feeling scrolling it inside the content.