docs: mark form properties in TextArea, StepInput #7859
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pskelin
approved these changes
Nov 16, 2023
ilhan007
added a commit
to SAP/ui5-webcomponents-ngx
that referenced
this pull request
Dec 5, 2023
- Select web component has new property "value" that should fix FormControl issues as the Select ngx wrapper relies on setting/getting value SAP/ui5-webcomponents#7865 - TextArea and StepInput now provide @formEvents, @formProperty so that respective ngx wrappers are extending the GenericControlValueAccessor and thus support FormControl properly SAP/ui5-webcomponents#7859
ilhan007
added a commit
to SAP/ui5-webcomponents-ngx
that referenced
this pull request
Dec 6, 2023
* feat: update to ui5-webcomponents 1.20.0 - Select web component has new property "value" that should fix FormControl issues as the Select ngx wrapper relies on setting/getting value SAP/ui5-webcomponents#7865 - TextArea and StepInput now provide @formEvents, @formProperty so that respective ngx wrappers are extending the GenericControlValueAccessor and thus support FormControl properly SAP/ui5-webcomponents#7859 * fix: fixed generator and parser to use some of the types directly (#104) * fix: fixed component parsing and generation * fix: using only public methods * fix: updated snapshots * chore: updated snapshots --------- Co-authored-by: Giorgi Cheishvili <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding these tags to the form related "value" property, used by the ui5-webc-ngx wrappers to properly generate the required value accessors so the ui5-webc-ngx wrappers work in Angular reactive forms.