feat(ui5-calendar-legend): introduce ui5-calendar-legend component #7706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
reviewed
Oct 27, 2023
ilhan007
reviewed
Oct 27, 2023
ilhan007
reviewed
Oct 27, 2023
ilhan007
reviewed
Oct 27, 2023
ilhan007
reviewed
Oct 27, 2023
ilhan007
reviewed
Oct 31, 2023
ilhan007
reviewed
Oct 31, 2023
ilhan007
reviewed
Oct 31, 2023
ilhan007
reviewed
Oct 31, 2023
ilhan007
reviewed
Oct 31, 2023
ilhan007
reviewed
Oct 31, 2023
ilhan007
reviewed
Oct 31, 2023
ilhan007
reviewed
Nov 1, 2023
hinzzx
changed the title
nnaydenow
requested changes
Jan 23, 2024
nnaydenow
previously requested changes
Feb 7, 2024
There was a problem hiding this comment.
In openui5 you can reach the calendar legend with tab, but here it's not possible.
In ui5 tabchain is: month , year, calendar and finishes with legend
Here tabchain is: calendar, month, year (legend is inclued if you click on some item inside it and then the chain is calendar, month, year, legend)
Also please change all since tag that remain to version 1.23.0
1 task
nnaydenow
reviewed
Feb 12, 2024
nnaydenow
reviewed
Feb 14, 2024
nnaydenow
reviewed
Feb 14, 2024
tsanislavgatev
approved these changes
Feb 14, 2024
tsanislavgatev
pushed a commit
that referenced
this pull request
Feb 20, 2024
…7706) Introducing the new CalendarLegend, CalendarLegendItem, SpecialCalendarDate Web Components. The Calendar Legend has four properties: *hideToday (hide-today) - Hides the 'Today' item in the Calendar Legend; *hideSelectedDay (hide-selected-day) - Hides the 'Selected' item in the Calendar Legend; *hideWorkingDay (hide-working-day) - Hides the 'Working Day' item in the Calendar Legend; *hideNonWorkingDay (hide-non-working-day) - Hides the 'Non-Working Day' item in the Calendar Legend; Accepting <ui5-calendar-legend-item>; ------- The Calendar Legend Item has two properties: type - Accepting string value of ("Type01"..."Type20"); ------- SpecialCalendarDate accepts the property: type - which should be a string value of ("Type01"..."Type20"); emphasizing the special days in the Calendar.
|
Is there a particular reason for not having a top-level element in the calendar's shadow root? @hinzzx UI5Element.ts:563 The shadow DOM for ui5-calendar does not have a top level element, the getDomRef() method might not work as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1:
Introducing the
<ui5-calendar-legend>components as Part 1 of the feature request about having Classic UI5-like Calendar Legend component.Currently our
<ui5-calendar-legend>component presents only the default 4 types (Today, Selected, Working and NonWorking).It has 4 properties:
hideToday(hide-today) - Hides the 'Today' item in the Calendar Legend;hideSelectedDay(hide-selected-day) - Hides the 'Selected' item in the Calendar Legend;hideWorkingDay(hide-working-day) - Hides the 'Working Day' item in the Calendar Legend;hideNonWorkingDay(hide-non-working-day) - Hides the 'Non-Working Day' item in the Calendar Legend;Part 2:
Part 3:
<ui5-calendar-legend>with the<ui5-calendar>.SpecialCalendarDates, emphasizing special days in the Calendar;