Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-select): scroll item into view on keyboard navigation #7370

Merged
merged 8 commits into from
Aug 31, 2023
Merged

fix(ui5-select): scroll item into view on keyboard navigation #7370

merged 8 commits into from
Aug 31, 2023

Conversation

kgogov
Copy link
Member

@kgogov kgogov commented Jul 24, 2023

Fixes: #7164

@kgogov kgogov marked this pull request as draft July 24, 2023 14:21
@github-actions github-actions bot added the Stale label Aug 18, 2023
@MapTo0
Copy link
Member

MapTo0 commented Aug 24, 2023

Hello Colleagues, any progress with that?

@kgogov kgogov removed the Stale label Aug 24, 2023
@kgogov kgogov marked this pull request as ready for review August 24, 2023 14:53
@kgogov
Copy link
Member Author

kgogov commented Aug 24, 2023

Hi @MapTo0, It is ready for review. Sorry for the delay..

@kgogov kgogov requested a review from a team August 30, 2023 10:12
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova self-assigned this Aug 31, 2023
@kgogov kgogov merged commit 8ecd118 into SAP:main Aug 31, 2023
6 checks passed
@kgogov kgogov deleted the ui5-select-fix branch August 31, 2023 18:43
@ilhan007
Copy link
Member

@kgogov, I am writting this just in case:
did you check if this works with Select + SelectMenu or at least not breaking it.

ilhan007 pushed a commit that referenced this pull request Sep 1, 2023
@kgogov @ilhan007
fix(ui5-select): scroll item into view on keyboard navigation (#7370)
5a45725 
* fix(ui5-select): scroll item into view on keyboard navigation

Fixes: #7164
@kgogov
Copy link
Member Author

kgogov commented Sep 1, 2023

@ilhan007

I apologize for not having examined this specific scenario, and I acknowledge the concern you've raised.
It appears that there is an issue with the keyboard navigation when using the Select with the menu property configured.

It's important to note that this problem exists both with and without the changes I made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova PetyaMarkovaBogdanova approved these changes

Assignees

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-select: List not scrolling in case of keyboard navigation
4 participants
@kgogov @MapTo0 @ilhan007 @PetyaMarkovaBogdanova