Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-tokenizer): change indicator's text when there are no visible tokens #7327

Merged
merged 4 commits into from
Jul 23, 2023
Merged

feat(ui5-tokenizer): change indicator's text when there are no visible tokens #7327

merged 4 commits into from
Jul 23, 2023

Conversation

niyap
Copy link
Contributor

@niyap niyap commented Jul 13, 2023 •
edited
Loading

FIXES: #7250
BGSOFUIRILA-3653

elenastoyanovaa
elenastoyanovaa requested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it applicable to add tests for the standalone tokenizer?

packages/main/src/i18n/messagebundle.properties Show resolved Hide resolved
packages/main/test/specs/MultiComboBox.spec.js Outdated Show resolved Hide resolved
packages/main/test/specs/MultiInput.spec.js Show resolved Hide resolved
@niyap
Copy link
Contributor Author

niyap commented Jul 13, 2023

is it applicable to add tests for the standalone tokenizer?

Currently, there is no separate file for ui5-tokenizer related tests. We can plan such action in future

elenastoyanovaa
elenastoyanovaa requested changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an issue link or JIRA in the PR description

@niyap niyap merged commit 27f690e into main Jul 23, 2023
5 checks passed
@niyap niyap deleted the moreitemstext branch July 23, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenastoyanovaa elenastoyanovaa elenastoyanovaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MultiInput]: it shows "x more" instead of "x items" whenever the first label is greater than the input
2 participants
@niyap @elenastoyanovaa