fix(ui5-illustrated-message): support collection based illustration loading #7318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobrinyonkov
changed the title
dobrinyonkov
force-pushed
the
collection-based-illustration-loader
branch
from
732672a
to
9eed62f
Compare
plamenivanov91
requested changes
Jul 26, 2023
plamenivanov91
approved these changes
Aug 2, 2023
nnaydenow
previously requested changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change branches the
ui5-illustrated-messageassets into collections - v4, v5, v5/hc.With this we aim to display new illustrations only for the new horizon theme and a simple version of the illustrations for the horizon high contrast themes.
How it works
Consumers of the
ui5-illustrated-messagecomponent should make no changes to their code in order to display the new illustrations. The new assets will be loaded automatically by theui5-illustrated-messagedepending on the current theme.Technical details
New illustrations are located under the
illustration-v5directory.The js modules of the illustrations now hold their collection key. The key is provided when an illustration is registered.
The script
generate-js-imports/illustrations.jsused to generate the dynamic imports for all the sets (base and tnt) at the same time. To reduce complexity caused by introducing collection based structure on top of the sets, the script is changed and called for all different variantions of the collection/sets separately.Related to: #7195